[Mesa-dev] [PATCH 03/16] main: fix the validation of the number of samples

[Jason Ekstrand]

On Mon, Feb 23, 2015 at 12:51 AM, Martin Peres <martin.peres at linux.intel.com
> wrote:

> On 20/02/15 20:38, Laura Ekstrand wrote:
>
>> Please provide a page number and a section title in your spec comment.
>>
>
> I'm not very fond of giving the page number as Khronos updates the pdf
> quite often
> and the page number may change. Since I see so little people write the pdf
> page
> number, is there a policy in place?
>
> Anyway, I updated the commit locally and I'll be updating all the other
> patches.
>

People do tend to use page numbers from what I've seen.  Yes, it has the
potential to get out-of-sync but probably never by more than a page or
two.  I don't thnk spec updates are all that substantial, especially in
older versions.  You could also give a section number (down to the
subsection) but that isn't quite as nice especially when the subsections
are large.  The big point is not to say "Here's a quote from *somewhere* in
this 300 page PDF document.  Go fish!" :-)
--Jason


>
>> Thanks.
>>
>> On Mon, Feb 16, 2015 at 6:13 AM, Martin Peres <
>> martin.peres at linux.intel.com <mailto:martin.peres at linux.intel.com>>
>> wrote:
>>
>>     Maybe this should be the job of the dispatch layer.
>>
>>     Signed-off-by: Martin Peres <martin.peres at linux.intel.com
>>     <mailto:martin.peres at linux.intel.com>>
>>
>>     ---
>>      src/mesa/main/multisample.c | 9 +++++++++
>>      1 file changed, 9 insertions(+)
>>
>>     diff --git a/src/mesa/main/multisample.c b/src/mesa/main/multisample.c
>>     index 1f3fa0c..a0a659b 100644
>>     --- a/src/mesa/main/multisample.c
>>     +++ b/src/mesa/main/multisample.c
>>     @@ -150,6 +150,15 @@ GLenum
>>      _mesa_check_sample_count(struct gl_context *ctx, GLenum target,
>>                               GLenum internalFormat, GLsizei samples)
>>      {
>>     +   /* From the OpenGL core 3.0 spec, section 2.5:
>>     +    *
>>     +    * "If a negative number is provided where an argument of type
>>     sizei or
>>     +    * sizeiptr is specified, the error INVALID VALUE is generated."
>>     +    */
>>     +   if (samples < 0) {
>>     +      return GL_INVALID_VALUE;
>>     +   }
>>     +
>>         /* If ARB_internalformat_query is supported, then treat its
>>     highest
>>          * returned sample count as the absolute maximum for this
>>     format; it is
>>          * allowed to exceed MAX_SAMPLES.
>>     --
>>     2.3.0
>>
>>     _______________________________________________
>>     mesa-dev mailing list
>>     mesa-dev at lists.freedesktop.org <mailto:mesa-dev at lists.freedesktop.org
>> >
>>     http://lists.freedesktop.org/mailman/listinfo/mesa-dev
>>
>>
>>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20150223/269cda1c/attachment-0001.html>