[Mesa-dev] [PATCH] mesa: add a missing GS support check in GetActiveUniformBlockiv

[Ian Romanick]

Nice catch... are there still any platforms in Mesa that support UBOs
(part of OpenGL 3.1) but not geometry shaders (part of OpenGL 3.2)?  I
guess there are a couple Intel platforms where we could probably enable
UBOs but will never have geometry shaders (Iron Lake)...

Either way,

Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>

On 02/23/2015 12:02 PM, Marek Olšák wrote:
> From: Marek Olšák <marek.olsak at amd.com>
> 
> ---
>  src/mesa/main/uniforms.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/src/mesa/main/uniforms.c b/src/mesa/main/uniforms.c
> index e471b87..4bb3dfb 100644
> --- a/src/mesa/main/uniforms.c
> +++ b/src/mesa/main/uniforms.c
> @@ -1142,6 +1142,8 @@ _mesa_GetActiveUniformBlockiv(GLuint program,
>        return;
>  
>     case GL_UNIFORM_BLOCK_REFERENCED_BY_GEOMETRY_SHADER:
> +      if (!_mesa_has_geometry_shaders(ctx))
> +         break;
>        params[0] = shProg->UniformBlockStageIndex[MESA_SHADER_GEOMETRY][uniformBlockIndex] != -1;
>        return;
>  
>