[Mesa-dev] [PATCH 3/4] i965/fs: Make emit_shader_time_end() insert before EOT.

Pohjolainen, Topi topi.pohjolainen at intel.com
Fri Feb 27 04:10:10 PST 2015

On Fri, Feb 27, 2015 at 12:06:01AM -0800, Kenneth Graunke wrote:
> Previously, we emitted the shader-time epilogue from emit_fb_writes(),
> during the middle of looping through color regions (or emit_urb_writes
> for the VS).  This is duplicated several times and rather awkward.
> I need to fix a bug in our FB write handling, and it will be a lot
> easier if we move emit_shader_time_end() out of there.
> Now, we simply emit FB writes/URB writes, and subsequently have
> emit_shader_time_end() insert instructions before the final SEND with
> EOT.  Not only is this simpler, it's actually a slight improvement:
> we now include the MOVs to set up the final FB write payload in our
> shader-time measurements.
> Note that INTEL_DEBUG=shader_time only exists on Gen7+, and uses
> send-from-GRF.  (In the past, we might have hit trouble where both
> attempt to use MRFs for messages; that's not a problem now.)
> Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>

Reviewed-by: Topi Pohjolainen <topi.pohjolainen at intel.com>

More information about the mesa-dev mailing list