[Mesa-dev] [PATCH 1/4] i965: Rename some PIPE_CONTROL flags

Kenneth Graunke kenneth at whitecape.org
Sat Feb 28 00:19:28 PST 2015


On Friday, February 27, 2015 10:22:08 AM Ben Widawsky wrote:
> I'm not really sure of the origins of the existing flag names. Modern docs have
> some slightly different names. Having the correct names makes it easier to
> determine if existing PIPE_CONTROL flag settings are correct, as well as making
> adding new PIPE_CONTROLs easier.
> 
> This originally came up while I was trying to implement workarounds and spotted
> some things called, "flush" which should have been called "invalidate."
> 
> Signed-off-by: Ben Widawsky <ben at bwidawsk.net>
> ---
>  src/mesa/drivers/dri/i965/brw_program.c       | 10 +++++-----
>  src/mesa/drivers/dri/i965/gen6_vs_state.c     |  2 +-
>  src/mesa/drivers/dri/i965/gen8_depth_state.c  |  2 +-
>  src/mesa/drivers/dri/i965/intel_batchbuffer.c |  8 ++++----
>  src/mesa/drivers/dri/i965/intel_reg.h         |  6 +++---
>  5 files changed, 14 insertions(+), 14 deletions(-)

Thanks, this is much nicer.

Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20150228/31c22c40/attachment.sig>


More information about the mesa-dev mailing list