[Mesa-dev] [PATCH:mesa] Bracket arguments to tr so they work with Solaris tr

Emil Velikov emil.l.velikov at gmail.com
Sun Jan 4 11:34:56 PST 2015


Hi Alan,
On 03/01/15 22:28, Alan Coopersmith wrote:
> https://www.gnu.org/savannah-checkouts/gnu/autoconf/manual/autoconf-2.69/html_node/Limitations-of-Usual-Tools.html#index-g_t_0040command_007btr_007d-1842
> 
> Without this fix, egl fails to build on Solaris, with the error:
> 
> <command-line>:0:22: error: '_EGL_PLATFORM_x11' undeclared (first use in this function)
> egldisplay.c:207:31: note: in expansion of macro '_EGL_NATIVE_PLATFORM'
>              native_platform = _EGL_NATIVE_PLATFORM;
>                                ^
> 
Trivial note - the sed command has picked up the missing -e parameter ;)
I'm thinking about using $SED consistently throughout (and add the
missing -e) in a separate patch(es). Any objections ?

Reviewed-by: Emil Velikov <emil.l.velikov at gmail.com>

If you're planning to push this please add the following line.
Alternatively I'll add it as I push it in a couple of days.

Cc: 10.3 10.4 <mesa-stable at lists.freedesktop.org>

Thanks
Emil

> Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>
> ---
>  configure.ac |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/configure.ac b/configure.ac
> index b5805f6..a008cbf 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -1584,7 +1584,7 @@ done
>  # libEGL wants to default to the first platform specified in
>  # ./configure.  parse that here.
>  if test "x$egl_platforms" != "x"; then
> -    FIRST_PLATFORM_CAPS=`echo $egl_platforms | sed 's| .*||' | tr 'a-z' 'A-Z'`
> +    FIRST_PLATFORM_CAPS=`echo $egl_platforms | sed -e 's| .*||' | tr '[[a-z]]' '[[A-Z]]'`
>      EGL_NATIVE_PLATFORM="_EGL_PLATFORM_$FIRST_PLATFORM_CAPS"
>  else
>      EGL_NATIVE_PLATFORM="_EGL_INVALID_PLATFORM"
> 



More information about the mesa-dev mailing list