[Mesa-dev] [PATCH:mesa] Bracket arguments to tr so they work with Solaris tr

[Alan Coopersmith]

On 01/ 4/15 11:34 AM, Emil Velikov wrote:
> Hi Alan,
> On 03/01/15 22:28, Alan Coopersmith wrote:
>> https://www.gnu.org/savannah-checkouts/gnu/autoconf/manual/autoconf-2.69/html_node/Limitations-of-Usual-Tools.html#index-g_t_0040command_007btr_007d-1842
>>
>> Without this fix, egl fails to build on Solaris, with the error:
>>
>> <command-line>:0:22: error: '_EGL_PLATFORM_x11' undeclared (first use in this function)
>> egldisplay.c:207:31: note: in expansion of macro '_EGL_NATIVE_PLATFORM'
>>               native_platform = _EGL_NATIVE_PLATFORM;
>>                                 ^
>>
> Trivial note - the sed command has picked up the missing -e parameter ;)

Oh, whoops.  That was left from my failed attempt to replace tr with a -e 'y/..'
flag to sed.

> I'm thinking about using $SED consistently throughout (and add the
> missing -e) in a separate patch(es). Any objections ?

Sounds good to me.

> Reviewed-by: Emil Velikov <emil.l.velikov at gmail.com>
>
> If you're planning to push this please add the following line.
> Alternatively I'll add it as I push it in a couple of days.
>
> Cc: 10.3 10.4 <mesa-stable at lists.freedesktop.org>

It's been a couple years since I've pushed to mesa, so I'm happy to let
you do the push so it's done right.

Thanks,

	-alan-