[Mesa-dev] [PATCH 1/3] main: Added _mesa_cube_level_complete to check for the completeness of an arbitrary cube map level.

Laura Ekstrand laura at jlekstrand.net
Mon Jan 5 09:52:43 PST 2015


Chad and Anuj, thanks for the catch.  I've fixed it.

Laura

On Thu, Jan 1, 2015 at 11:08 AM, Chad Versace <chad.versace at intel.com>
wrote:

> On 12/31/2014 05:26 PM, Laura Ekstrand wrote:
>
> > +/**
> > + * Check if the given cube map texture is "cube complete" as defined in
> > + * the OpenGL specification.
> > + */
> > +GLboolean
> > +_mesa_cube_complete(const struct gl_texture_object *texObj)
> > +{
> > +   _mesa_cube_level_complete(texObj, texObj->BaseLevel);
>
> You forgot to return here ^^^
> > +}
>
> This patch makes sense to me after our irc conversation.
> With the return fixed,
> Reviewed-by: Chad Versace <chad.versace at intel.com>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20150105/308ab2fb/attachment.html>


More information about the mesa-dev mailing list