[Mesa-dev] [PATCH] mesa: Add mesa SHA-1 functions

[Jose Fonseca]

On 07/01/15 19:11, Carl Worth wrote:
> On Wed, Jan 07 2015, Jose Fonseca wrote:
>> I lost bit track of email over the Christmas period.  Just noticed I had
>> flagged this one for replay. Sorry.
>
> No worries. Thanks for following up now. :-)
>
>> Do you still need me to test anything on Windows? If so are the patches
>> in some pull-able git repos by any chance?
>
> Yes, some testing on Windows would be great. I've got these patches
> here:
>
> 	git://people.freedesktop.org/~cworth/mesa
>
> And testing that the build works fine with or without one of the
> potential Windows crypto libraries available would be great. Look for
> lines like the following in the configure output:
>
>          Shader cache:    yes
>          With SHA1 from:  libnettle
>
> And you can manually control this by passing options such as:
>
> 	./configure --disable-shader-cache
>
> or:
>
> 	./configure --enable-shader-cache --with-sha1=CryptoAPI
>
> The possible values for --with-sha1 are listed in "./configure --help"
> and include the following:
>
> 	libc, libmd, libnettle, libgcrypt, libcrypto, libsha1,
> 	CommonCrypto, CryptoAPI
>
> As I said earlier in the thread, I've tested libnettle, libgcrypt, and
> libcrypto on my Linux machine. So any touch testing of any of the other
> options, (particularly those available only on Windows), would be great.
>
> In that branch, there's not actually any code that calls into any of the
> sha1 functions. So you'll basically just be testing configuration,
> building, and linking. If you'd like to go the extra step and verify
> that the code can be called and actually do something, then you could
> use something like the attached patch which simply prints the computed
> sha1 for any compiled shader.
>
> Please let me know if you have any questions, and what testing results
> you get.
>
> Thanks,
>
> -Carl
>

Note that Windows build is only supported with SCons.  Never with autobuild.


In fact, SCons build was broken on that branch, with Windows or Linux. 
I've pushed a few fixes to

   http://cgit.freedesktop.org/~jrfonseca/mesa/log/?h=sha1

This is enough to get things building without failing.  And in fact I

But I had to disable sha1.c building for now, until we have the 
HAVE_SHA1* detection on SCons too.


So my recommendation is: disable the shader cache on all scons builds, 
get this merged and working on master with automake, then I'll add the 
HAVE_SHA1 * checks on SCons and enable this as time permits.



Jose