[Mesa-dev] [PATCH] mesa: Add mesa SHA-1 functions

[Carl Worth]

On Thu, Jan 08 2015, Jose Fonseca wrote:
> Note that Windows build is only supported with SCons.  Never with
> autobuild.

OK. That's good for me to learn. I've requested that the folks doing our
automated build testing here will also start testing scons builds, so
hopefully on our end we can avoid breaking scons builds in the future.

> In fact, SCons build was broken on that branch, with Windows or Linux. 
> I've pushed a few fixes to
>
>    http://cgit.freedesktop.org/~jrfonseca/mesa/log/?h=sha1

Thanks. I've incorporated these fixes into my commits and rebased
everything onto the latest master. You can see what I have here:

	http://cgit.freedesktop.org/~cworth/mesa/log/?h=sha1

The only change I didn't pull in was the "|| defined(_WIN32)" to force
compilation of the CryptoAPI SHA-1 support on a Windows build, (since
this file won't even be compiled).

> This is enough to get things building without failing.  And in fact I

Looks like you didn't finish that sentence. Perhaps there was nothing
important there.

> So my recommendation is: disable the shader cache on all scons builds, 
> get this merged and working on master with automake, then I'll add the 
> HAVE_SHA1 * checks on SCons and enable this as time permits.

That sounds like a good plan. I can push what I've got above unless
there are any objections from anybody.

-Carl
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 818 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20150115/fad42d3a/attachment.sig>