[Mesa-dev] [PATCH v2 4/5] meta: Add a BlitFramebuffers-based implementation of TexSubImage

Neil Roberts neil at linux.intel.com
Tue Jan 13 07:05:50 PST 2015


Jason Ekstrand <jason at jlekstrand.net> writes:

> +   _mesa_GenTextures(1, &pbo_tex);
> +   pbo_tex_obj = _mesa_lookup_texture(ctx, pbo_tex);
> +   pbo_tex_obj->Target = depth > 2 ? GL_TEXTURE_2D_ARRAY : GL_TEXTURE_2D;

Did you miss this? It still looks like it should be depth > 1.

Assuming you change that it looks good to me.

Reviewed-by: Neil Roberts <neil at linux.intel.com>

Regards,
- Neil


More information about the mesa-dev mailing list