[Mesa-dev] [PATCH v2 4/5] meta: Add a BlitFramebuffers-based implementation of TexSubImage

[Jason Ekstrand]

On Tue, Jan 13, 2015 at 7:05 AM, Neil Roberts <neil at linux.intel.com> wrote:

> Jason Ekstrand <jason at jlekstrand.net> writes:
>
> > +   _mesa_GenTextures(1, &pbo_tex);
> > +   pbo_tex_obj = _mesa_lookup_texture(ctx, pbo_tex);
> > +   pbo_tex_obj->Target = depth > 2 ? GL_TEXTURE_2D_ARRAY :
> GL_TEXTURE_2D;
>
> Did you miss this? It still looks like it should be depth > 1.
>

I'll get that fixed locally.


>
> Assuming you change that it looks good to me.
>
> Reviewed-by: Neil Roberts <neil at linux.intel.com>
>

Thanks, However I'm in the process of reworking it substantially.  I'll get
that sent out today.
--Jason


>
> Regards,
> - Neil
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20150113/48b15d1c/attachment.html>