[Mesa-dev] [PATCH 04/12] gallium/util: improve dump functions

[Brian Paul]

On 07/21/2015 08:17 AM, Marek Olšák wrote:
> On Tue, Jul 21, 2015 at 3:56 PM, Brian Paul <brianp at vmware.com> wrote:
>> Just a couple minor nits...
>>
>> On 07/16/2015 10:54 AM, Marek Olšák wrote:
>>>
>>> From: Marek Olšák <marek.olsak at amd.com>
>>>
>>> ---
>>>    src/gallium/auxiliary/util/u_dump.h         |  20 ++-
>>>    src/gallium/auxiliary/util/u_dump_defines.c |  41 +++++
>>>    src/gallium/auxiliary/util/u_dump_state.c   | 233
>>> ++++++++++++++++++++++------
>>>    3 files changed, 241 insertions(+), 53 deletions(-)
>>>
>>> diff --git a/src/gallium/auxiliary/util/u_dump.h
>>> b/src/gallium/auxiliary/util/u_dump.h
>>> index 3ddf518..1c0e879 100644
>>> --- a/src/gallium/auxiliary/util/u_dump.h
>>> +++ b/src/gallium/auxiliary/util/u_dump.h
>>> @@ -88,14 +88,16 @@ util_dump_tex_filter(unsigned value, boolean
>>> shortened);
>>>    const char *
>>>    util_dump_query_type(unsigned value, boolean shortened);
>>>
>>> +const char *
>>> +util_dump_mode(unsigned value, boolean shortened);
>>
>>
>> Maybe util_dump_prim_mode().  And maybe I'm confused, but I don't see the
>> implementation of this function in the .c file.
>
> The DEFINE_UTIL_DUMP_CONTINUOUS macro does that.

OK, with nits fixed, Reviewed-by: Brian Paul <brianp at vmware.com>