[Mesa-dev] [PATCH 01/18] gallium/util: clear up that debug_get_flags_option returns a 64-bit mask

Kai Wasserbäch kai at dev.carbon-project.org
Wed Jul 29 08:18:07 PDT 2015

Marek Olšák wrote on 28.07.2015 21:42:
> On Tue, Jul 28, 2015 at 6:35 PM, Kai Wasserbäch
> <kai at dev.carbon-project.org> wrote:
>> Marek Olšák wrote on 28.07.2015 12:05:
>>> From: Marek Olšák <marek.olsak at amd.com>
>>> ---
>>>  src/gallium/auxiliary/util/u_debug.c | 8 ++++----
>>>  src/gallium/auxiliary/util/u_debug.h | 6 +++---
>>>  2 files changed, 7 insertions(+), 7 deletions(-)
>> The receiving variables in the callers should probably be fixed up as well,
>> right? Most of them seem to be unsigned long or just unsigned. (E.g. in
>> debug_flags in r600_common_screen is an unsigned)
>> But maybe that can be ignored?
>> Though somebody with deeper knowledge of the code should give you a R-b, you can
>> have mine, for what it is worth, with the callers fixed:
>>         Reviewed-by: Kai Wasserbäch <kai at dev.carbon-project.org>
> The type of r600_common_screen::debug_flags is changed by a later patch.
> I don't think the callers need updating if they don't use the higher
> bits. The behavior remains the same. For radeon, the first patch using
> the higher bits updates the type as well.

Ok, I would have done it in this patch. Anyway, after your explanation your
patch seems fine as is.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 630 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20150729/61d08e03/attachment-0001.sig>

More information about the mesa-dev mailing list