[Mesa-dev] [PATCH] i965/bxt: Support 3src simd16 instructions

[Ben Widawsky]

On Wed, Jul 29, 2015 at 05:51:38PM +0100, Neil Roberts wrote:
> I tested this on my BXT by running the glsl-fs-color-matrix test (which
> ends up using MAD in SIMD16) and it worked fine.
> 
> Tested-by: Neil Roberts <neil at linux.intel.com>
> Reviewed-by: Neil Roberts <neil at linux.intel.com>
> 
> - Neil

Crap. I just pushed this before I noticed this mail (I reconfigured my spam
stuff recently and I have a bunch of mails going to spam). I apologize for
missing your r-b; thanks for testing and reviewing though.

> 
> Ben Widawsky <benjamin.widawsky at intel.com> writes:
> 
> > This is easily accomplished by moving simd16 3src to GEN9_FEATURES.
> >
> > Signed-off-by: Ben Widawsky <ben at bwidawsk.net>
> > ---
> >  src/mesa/drivers/dri/i965/brw_device_info.c | 6 ++----
> >  1 file changed, 2 insertions(+), 4 deletions(-)
> >
> > diff --git a/src/mesa/drivers/dri/i965/brw_device_info.c b/src/mesa/drivers/dri/i965/brw_device_info.c
> > index 51a91b6..1efe546 100644
> > --- a/src/mesa/drivers/dri/i965/brw_device_info.c
> > +++ b/src/mesa/drivers/dri/i965/brw_device_info.c
> > @@ -315,7 +315,8 @@ static const struct brw_device_info brw_device_info_chv = {
> >        .min_vs_entries = 64,                         \
> >        .max_vs_entries = 1664,                       \
> >        .max_gs_entries = 640,                        \
> > -   }
> > +   },                                               \
> > +   .supports_simd16_3src = true                     \
> >  
> >  static const struct brw_device_info brw_device_info_skl_early = {
> >     GEN9_FEATURES, .gt = 1,
> > @@ -324,17 +325,14 @@ static const struct brw_device_info brw_device_info_skl_early = {
> >  
> >  static const struct brw_device_info brw_device_info_skl_gt1 = {
> >     GEN9_FEATURES, .gt = 1,
> > -   .supports_simd16_3src = true,
> >  };
> >  
> >  static const struct brw_device_info brw_device_info_skl_gt2 = {
> >     GEN9_FEATURES, .gt = 2,
> > -   .supports_simd16_3src = true,
> >  };
> >  
> >  static const struct brw_device_info brw_device_info_skl_gt3 = {
> >     GEN9_FEATURES, .gt = 3,
> > -   .supports_simd16_3src = true,
> >  };
> >  
> >  static const struct brw_device_info brw_device_info_bxt = {
> > -- 
> > 2.4.6
> >
> > _______________________________________________
> > mesa-dev mailing list
> > mesa-dev at lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/mesa-dev