[Mesa-dev] [Bug 91020] Mesa's demo / tools won't compile since EGL changes

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Thu Jul 30 08:15:25 PDT 2015


--- Comment #5 from Emil Velikov <emil.l.velikov at gmail.com> ---
(In reply to George Diamantopoulos from comment #4)
> Created attachment 117106 [details] [review]
> Fix build against EGL implementations that don't support  the
> EGL_MESA_screen_surface extension
> There is a patch by Frank Binns (posted on mesa-dev) since 2012 on this...
> It worked for me, so I'm attaching it here

While this should work and has been the approach used so far in mesa-demos, I'm
having second doubts how wise of an idea it is.

In this particular example, this will result in a "empty" demo/program which
won't do anything when run on a EGL_MESA_screen_surface capable driver.

I.e. even if your system is perfectly fine, the binary build by your
distro/elsewhere with the missing definition will be useless.

May I suggest that we add the relevant defines, after including the *GL
headers. This way the binary will work on compatible systems, and (should) bail
out if the extension is not supported.

One could also fix the other similar cases, while at it ;-) Git grep shows some
~120 lines :-P

You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20150730/7a4cf227/attachment.html>

More information about the mesa-dev mailing list