[Mesa-dev] [PATCH 19/19] st/mesa: enable shader subroutine

[Steven Newbury]

On Sun, 2015-05-31 at 20:41 -0700, Kenneth Graunke wrote:
> On Monday, June 01, 2015 11:35:03 AM Dave Airlie wrote:
> > From: Dave Airlie <airlied at redhat.com>
> > 
> > I'm not sure if we shouldn't enable this everywhere
> > and rip out the API checks,
> > 
> > discuss,
> > 
> > Signed-off-by: Dave Airlie <airlied at redhat.com>
> > ---
> >  src/mesa/state_tracker/st_extensions.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/src/mesa/state_tracker/st_extensions.c 
> > b/src/mesa/state_tracker/st_extensions.c
> > index b1057f3..3b828fa 100644
> > --- a/src/mesa/state_tracker/st_extensions.c
> > +++ b/src/mesa/state_tracker/st_extensions.c
> > @@ -598,6 +598,7 @@ void st_init_extensions(struct pipe_screen 
> > *screen,
> >     extensions->ARB_half_float_vertex = GL_TRUE;
> >     extensions->ARB_internalformat_query = GL_TRUE;
> >     extensions->ARB_map_buffer_range = GL_TRUE;
> > +   extensions->ARB_shader_subroutine = GL_TRUE;
> >     extensions->ARB_texture_border_clamp = GL_TRUE; /* XXX temp */
> >     extensions->ARB_texture_cube_map = GL_TRUE;
> >     extensions->ARB_texture_env_combine = GL_TRUE;
> > 
> 
> I know people have talked about enabling it everywhere 1.30+ is
> available.  That makes some sense.
> 
> Here's an argument for keeping it optional:  We don't want people 
> using
> this extension, so there's no value - in fact, negative value - to
> exposing it unless we have to.
Ignorant question, but why don't you want people using it?

>   Drivers that can't do 4.0, such as
> Sandybridge, could avoid advertising it if we kept it optional.
> 
> I'm happy to defer to majority opinion.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: This is a digitally signed message part
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20150601/e0dc9c23/attachment.sig>