[Mesa-dev] [PATCH 1/2] i965: Don't use a temporary when generating an indirect sample

Neil Roberts neil at linux.intel.com
Mon Jun 1 07:19:59 PDT 2015

Many thanks for all the reviews and testing. I've pushed the two

The remaining sampler_array_indexing tests that fail on SKL (the gs
ones) are because of a separate problem described in this patch:


I'm not really sure whether that's the cleanest solution so any thoughts
by folks more knowledgeable than me would be welcome.

Weirdly, not having that patch seems to make fs-nonzero-base and
sampler-nonconst-2d-grad also fail even though if I run them separately
after a reboot they work fine. Without that patch it ends up sending a
sample message with a null register for the message base, which is
supposed to include a header on SKL. Maybe that puts the hardware into
some weird state?

- Neil

Anuj Phogat <anuj.phogat at gmail.com> writes:

> Fixes sampler_array_indexing/fs-simple and
> sampler_array_indexing/fs-nonzero-base tests on SKL.
> Tested-by: Anuj Phogat <anuj.phogat at gmail.com>

More information about the mesa-dev mailing list