[Mesa-dev] [PATCH 1/2] prog_to_nir: Remove from op_trans[] opcodes handled in the switch.

Kenneth Graunke kenneth at whitecape.org
Mon Jun 1 17:54:05 PDT 2015

On Monday, June 01, 2015 01:03:09 PM Matt Turner wrote:
> ---
> I'm not missing something, am I?
>  src/mesa/program/prog_to_nir.c | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)

Nope, I think this was copy and pasted.  IIRC these do scalar operations
and splat results, unlike most ALU operations.  It might be nice to keep
the table driven approach, but combine the code to handle those cases...
but I'm not positive how to do that, and it doesn't save much anyway.

Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20150601/5490b121/attachment-0001.sig>

More information about the mesa-dev mailing list