[Mesa-dev] [RFC v2 12/15] i965: correct VALIGN for 2d textures on Skylake

Neil Roberts neil at linux.intel.com
Tue Jun 2 03:39:26 PDT 2015

Actually, having said that I think it would make more sense to change
the line to:

      return brw->gen >= 9 ? j * 4 : j;

The 4 that it was returning for Gen<9 is supposed to represent the block
height and I don't think there's any reason to hard-code it seeing as we
are now querying the block height anyway. The later patch about
combining the two functions would need to be changed too.

- Neil

Neil Roberts <neil at linux.intel.com> writes:

> Looks good to me.
> Reviewed-by: Neil Roberts <neil at linux.intel.com>
> - Neil
> Anuj Phogat <anuj.phogat at gmail.com> writes:
>> Adding Neil to Cc who committed 4ab8d59.
>> Reviewed-by: Anuj Phogat <anuj.phogat at gmail.com>

More information about the mesa-dev mailing list