[Mesa-dev] [PATCH] mesa: reference built-in uniforms into gl_uniform_storage

Martin Peres martin.peres at free.fr
Thu Jun 4 02:56:39 PDT 2015


On 04/06/15 12:53, Jose Fonseca wrote:
> On 31/05/15 08:10, Tapani wrote:
>>
>> I've read this a couple of times now and cannot spot any users of
>> storage that would be making a wrong assumption, you've fixed these and
>> I trust Jenkins was OK for i915?
>>
>> Everything is ok if you remove 'I think' and 'Hopefully' from commit
>> message :)
>
> Martin's fears were legitimate, as this change just caused +2729 tests 
> to fail with piglit. :)
>
> So there must be some code that still needs to be updated somewhere 
> (maybe in the gallium specific paths).  Question is then: Where's Wally?
>
> Jose

Thanks for the notification Jose! I will try running piglit on llvmpipe 
and see if I can reproduce! I did not get any error on the intel driver. 
Will re-launch a test on our test platform, just in case!

Sorry,
Martin


More information about the mesa-dev mailing list