[Mesa-dev] [PATCH v2 02/82] glsl: Add ir_var_shader_storage

[Iago Toral]

On Thu, 2015-06-04 at 00:12 -0700, Jordan Justen wrote:
> On 2015-06-03 00:00:52, Iago Toral Quiroga wrote:
> > From: Kristian Høgsberg <krh at bitplanet.net>
(...)
> > diff --git a/src/glsl/ir.h b/src/glsl/ir.h
> > index fab1cd2..dd10298 100644
> > --- a/src/glsl/ir.h
> > +++ b/src/glsl/ir.h
> > @@ -323,6 +323,7 @@ protected:
> >  enum ir_variable_mode {
> >     ir_var_auto = 0,     /**< Function local variables and globals. */
> >     ir_var_uniform,      /**< Variable declared as a uniform. */
> > +   ir_var_shader_storage,   /**< Variable declared as an ssbo. */
> >     ir_var_shader_in,
> >     ir_var_shader_out,
> >     ir_var_function_in,
> > @@ -444,7 +445,9 @@ public:
> >      */
> >     inline bool is_in_uniform_block() const
> 
> How about renaming this? is_in_buffer_block? (shader storage and
> uniform buffer interface blocks...)

Sure, do you think we should do the rename in the same commit or
separately?

Iago

> With that, Reviewed-by: Jordan Justen <jordan.l.justen at intel.com>