[Mesa-dev] [Mesa-stable] [PATCH 1/2] glsl: Allow dynamic sampler array indexing with GLSL ES < 3.00

Tapani Pälli tapani.palli at intel.com
Fri Jun 5 04:40:28 PDT 2015

On 06/03/2015 02:10 PM, Emil Velikov wrote:
> Hi Tapani,
> On 19 May 2015 at 13:01, Tapani Pälli <tapani.palli at intel.com> wrote:
>> Dynamic indexing of sampler arrays is prohibited by GLSL ES 3.00.
>> Earlier versions allow 'constant-index-expression' indexing, where
>> index can contain a loop induction variable.
>> Patch allows dynamic indexing for sampler arrays when GLSL ES < 3.00.
>> This change makes 'sampler-array-index.frag' parser test in Piglit
>> pass + fishgl.com works when running Chrome on OpenGL ES 2.0 backend
>> v2: small change and some more commit message (Tapani)
>> v3: refactor checks to make it more readable (Ian Romanick)
>> Signed-off-by: Tapani Pälli <tapani.palli at intel.com>
>> Signed-off-by: Kalyan Kondapally <kalyan.kondapally at intel.com>
>> Cc: "10.5" and "10.6" <mesa-stable at lists.freedesktop.org>
>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=84225
> Just a friendly reminder that this hasn't landed in master and won't
> be featuring in the stable branches (yet). Seems like this patch fell
> through the cracks, although let us know if that's not the case.

Thanks for the reminder. I did not receive r-b yet for these. We 
discussed this with Curro today and I'll be posting these again with 
some additional changes.

// Tapani

More information about the mesa-dev mailing list