[Mesa-dev] [PATCH 0/4] Fix some warnings caught by GCC5

Brian Paul brianp at vmware.com
Fri Jun 5 06:31:56 PDT 2015


Series looks good to me.

Reviewed-by: Brian Paul <brianp at vmware.com>


On 06/05/2015 06:31 AM, Martin Peres wrote:
> GCC5 apparently got the ability to remember if the output variables of
> a function have been initialized in all the codepathes. The first
> two patches fix real issues.
>
> The r600 patch seem to fix a real issue, but I have not spent too long
> looking at the code.
>
> GCC5 also became more annoying around logic operations and requires
> more parenthesis (last patch).
>
>
> Martin Peres (4):
>    main/version: make sure all the output variables get set in
>      get_gl_override
>    nouveau/compiler: init the size and code variables to NULL/0
>    r600/sb_sched: fix what appears to be a typo in a condition
>    softpipe/query: force parenthesis around a logical not
>
>   src/gallium/drivers/nouveau/nouveau_compiler.c | 2 +-
>   src/gallium/drivers/r600/sb/sb_sched.cpp       | 2 +-
>   src/gallium/drivers/softpipe/sp_query.c        | 2 +-
>   src/mesa/main/version.c                        | 3 ++-
>   4 files changed, 5 insertions(+), 4 deletions(-)
>



More information about the mesa-dev mailing list