[Mesa-dev] [PATCH 2/4] nouveau/compiler: init the size and code variables to NULL/0
Tobias Klausmann
tobias.johannes.klausmann at mni.thm.de
Fri Jun 5 13:38:54 PDT 2015
Mh especially GCC 5 seems to be picky about code, if we don't work
around we soon will only see warnings for every file. Even if the
compiler is buggy/to picky we should fix the code to not drown in
warnings... :-)
On 05.06.2015 22:23, Ilia Mirkin wrote:
>
> Sure. Fix it in GCC :) disable the bogus warning, whatever. I really
> really hate pandering to broken tools, sending the message that it's
> ok for the tools to be broken.
>
> On Jun 5, 2015 5:20 PM, "Martin Peres" <martin.peres at linux.intel.com
> <mailto:martin.peres at linux.intel.com>> wrote:
>
> On 05/06/15 17:12, Ilia Mirkin wrote:
>
>
> But if codegen fails, the code is never displayed as I recall.
> Again, this I'd going from memory...
>
>
> Good memory. It looks ugly though.
>
> In general, I would still want to fix the warning because I hate
> needing to revert my patches to check if I introduced warnings or
> not. In this particular case it is probably OK because no-one will
> likely touch this file for the foreseeable future :)
>
>
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
More information about the mesa-dev
mailing list