[Mesa-dev] [PATCH 02/38] i965/vec4: Introduce VEC4 IR builder.

Kenneth Graunke kenneth at whitecape.org
Sat Jun 6 23:03:49 PDT 2015


On Thursday, June 04, 2015 07:04:51 PM Francisco Jerez wrote:
> See "i965/fs: Introduce FS IR builder." for the rationale.
> 
> v2: Drop scalarizing VEC4 builder.
> v3: Take a backend_shader as constructor argument.  Improve handling
>     of debug annotations and execution control flags.
> ---
>  src/mesa/drivers/dri/i965/Makefile.sources   |   1 +
>  src/mesa/drivers/dri/i965/brw_vec4_builder.h | 573 +++++++++++++++++++++++++++
>  2 files changed, 574 insertions(+)
>  create mode 100644 src/mesa/drivers/dri/i965/brw_vec4_builder.h

NAK on landing this one for now - we don't want to land dead code.
I'd be happy to consider landing it once something uses it.

It seems Matt's reviewed the rest of the series in detail, so I'm not
planning to.  As long as he's happy, it's fine by me.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20150606/c5dfe932/attachment.sig>


More information about the mesa-dev mailing list