[Mesa-dev] [v4 PATCH 00/10] Implement extension ARB_framebuffer_no_attachments

[Connor Abbott]

On Tue, Jun 9, 2015 at 3:06 PM, Ian Romanick <idr at freedesktop.org> wrote:
> I've sent out review for all of the patches that don't already have R-b
> on them.  Before pushing, you should double check the whitespace.  In
> particular, it's hard to notice tabs and trailing whitespace when
> reviewing.  If you do 'git show origin/master..' and search for tab or
> '[[:space:]]*$'
>
> Also, if you 'chmod +x .git/hooks/pre-commit', git will inform you about
> certain errors when you try to commit.

Also, you can do "git rebase --whitespace=fix master" on your branch
to remove trailing whitespace from each commit (although this won't do
anything for tabs vs. spaces issues -- but that isn't as much of an
issue once you've configured things correctly).

>
> On 05/27/2015 02:49 AM, Kevin Rogovin wrote:
>> This patch series implements:
>>   - the needed functionality in Mesa-core for ARB_framebuffer_no_attachments
>>   - implements and enables the extension i965
>>
>> Kevin Rogovin (10):
>>   mesa: Define infrastructure for ARB_framebuffer_no_attachments
>>   mesa: Constants and functions for ARB_framebuffer_no_attachments
>>   mesa: Complete ARB_framebuffer_no_attachments in Mesa core
>>   mesa: add helper functions for geometry of gl_framebuffer
>>   mesa: helper function for scissor box of gl_framebuffer
>>   i965: Use _mesa_geometry_ functions appropriately
>>   mesa: mesa: function for testing if current frag-shader has atomics
>>   i965: execution of frag-shader when it has atomic buffer
>>   i965: enable ARB_framebuffer_no_attachments for Gen7+
>>   mark GL_ARB_framebuffer_no_attachments as done for i965
>>
>>  docs/GL3.txt                                       |   4 +-
>>  docs/relnotes/10.7.0.html                          |   4 +-
>>  .../glapi/gen/ARB_framebuffer_no_attachments.xml   |  32 +++
>>  src/mapi/glapi/gen/Makefile.am                     |   1 +
>>  src/mapi/glapi/gen/gl_API.xml                      |   4 +-
>>  src/mesa/drivers/dri/i965/brw_clip_state.c         |   9 +-
>>  src/mesa/drivers/dri/i965/brw_context.c            |   6 +
>>  src/mesa/drivers/dri/i965/brw_misc_state.c         |   9 +-
>>  src/mesa/drivers/dri/i965/brw_sf_state.c           |   6 +
>>  src/mesa/drivers/dri/i965/brw_state_upload.c       |   6 +-
>>  src/mesa/drivers/dri/i965/brw_wm.c                 |   7 +-
>>  src/mesa/drivers/dri/i965/brw_wm_surface_state.c   |  12 +-
>>  src/mesa/drivers/dri/i965/gen6_clip_state.c        |  10 +-
>>  src/mesa/drivers/dri/i965/gen6_multisample_state.c |   3 +-
>>  src/mesa/drivers/dri/i965/gen6_scissor_state.c     |  12 +-
>>  src/mesa/drivers/dri/i965/gen6_sf_state.c          |   3 +-
>>  src/mesa/drivers/dri/i965/gen6_viewport_state.c    |   5 +-
>>  src/mesa/drivers/dri/i965/gen6_wm_state.c          |   3 +-
>>  src/mesa/drivers/dri/i965/gen7_sf_state.c          |   3 +-
>>  src/mesa/drivers/dri/i965/gen7_viewport_state.c    |   5 +-
>>  src/mesa/drivers/dri/i965/gen7_wm_state.c          |   7 +-
>>  src/mesa/drivers/dri/i965/gen8_ps_state.c          |   3 +
>>  src/mesa/drivers/dri/i965/gen8_viewport_state.c    |   8 +-
>>  src/mesa/drivers/dri/i965/intel_extensions.c       |   1 +
>>  src/mesa/main/extensions.c                         |   1 +
>>  src/mesa/main/fbobject.c                           | 221 +++++++++++++++++++--
>>  src/mesa/main/fbobject.h                           |   6 +
>>  src/mesa/main/framebuffer.c                        |  64 ++++--
>>  src/mesa/main/framebuffer.h                        |  33 +++
>>  src/mesa/main/get.c                                |   1 +
>>  src/mesa/main/get_hash_params.py                   |   6 +
>>  src/mesa/main/mtypes.h                             |  61 +++++-
>>  src/mesa/main/tests/dispatch_sanity.cpp            |   4 +-
>>  33 files changed, 475 insertions(+), 85 deletions(-)
>>  create mode 100644 src/mapi/glapi/gen/ARB_framebuffer_no_attachments.xml
>>
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev