[Mesa-dev] [v4 PATCH 05/10] mesa: helper function for scissor box of gl_framebuffer

[Rogovin, Kevin]

Hi,

-----Original Message-----
From: Ian Romanick [mailto:idr at freedesktop.org] 
Sent: Wednesday, June 10, 2015 1:06 AM
To: Rogovin, Kevin; mesa-dev at lists.freedesktop.org
Subject: Re: [Mesa-dev] [v4 PATCH 05/10] mesa: helper function for scissor box of gl_framebuffer


>All of the changes in this function below this point seem unnecessary.
>If they are necessary, please explain why.  If they're not, mixing cosmetic changes and functional >changes is bad... don't do it. :)  That also avoids the issue of where to put the "+".

In truth, the raw diff hides the fact that this is actually the body of a new function taken from an old function. In v1 (and I think v2) I did not use xmax and ymax, but the code was severely over the 80 column limit and did a re-compute (which a reasonable compiler should likely realize and not do in compiled code). 

I am totally happy to make the body of the new function to be essentially identical to the body of the old function and thus leave it going past 80-columns and doing the re-compute. Would that be better?