[Mesa-dev] [PATCH] meta: Use is_power_of_two() helper function

[Tapani Pälli]

Reviewed-by: Tapani Pälli <tapani.palli at intel.com>

On 06/11/2015 02:50 AM, Anuj Phogat wrote:
> Signed-off-by: Anuj Phogat <anuj.phogat at gmail.com>
> ---
>   src/mesa/drivers/common/meta_blit.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/src/mesa/drivers/common/meta_blit.c b/src/mesa/drivers/common/meta_blit.c
> index bb21642..9cace2b 100644
> --- a/src/mesa/drivers/common/meta_blit.c
> +++ b/src/mesa/drivers/common/meta_blit.c
> @@ -82,7 +82,7 @@ setup_glsl_msaa_blit_scaled_shader(struct gl_context *ctx,
>      y_scale = samples * 0.5;
>
>      /* We expect only power of 2 samples in source multisample buffer. */
> -   assert(samples > 0 && (samples & (samples - 1)) == 0);
> +   assert(samples > 0 && is_power_of_two(samples));
>      while (samples >> (shader_offset + 1)) {
>         shader_offset++;
>      }
> @@ -263,7 +263,7 @@ setup_glsl_msaa_blit_shader(struct gl_context *ctx,
>      }
>
>      /* We expect only power of 2 samples in source multisample buffer. */
> -   assert(samples > 0 && (samples & (samples - 1)) == 0);
> +   assert(samples > 0 && is_power_of_two(samples));
>      while (samples >> (shader_offset + 1)) {
>         shader_offset++;
>      }
> @@ -434,7 +434,7 @@ setup_glsl_msaa_blit_shader(struct gl_context *ctx,
>             * (so the floating point exponent just gets increased), rather than
>             * doing a naive sum and dividing.
>             */
> -         assert((samples & (samples - 1)) == 0);
> +         assert(is_power_of_two(samples));
>            /* Fetch each individual sample. */
>            sample_resolve = rzalloc_size(mem_ctx, 1);
>            for (i = 0; i < samples; i++) {
>