[Mesa-dev] [PATCH v3] egl/dri2: implement platform_surfaceless

[Emil Velikov]

Hi Zach,

On 11 June 2015 at 03:25, Zach Reizner <zachr at google.com> wrote:
> From: Haixia Shi <hshi at chromium.org>
>
> The surfaceless platform is for off-screen rendering only. Render node support
> is required.
>
> Only consider the render nodes. Do not use normal nodes as they require
> auth hooks.
>
> v3: change platform_null to platform_surfaceless
> v4: make libdrm required for surfaceless
v4: make libdrm required for surfaceless, make sure it compiles :-)

> diff --git a/src/egl/drivers/dri2/egl_dri2.c b/src/egl/drivers/dri2/egl_dri2.c
> index 82f8843..877cf70 100644
> --- a/src/egl/drivers/dri2/egl_dri2.c
> +++ b/src/egl/drivers/dri2/egl_dri2.c

> @@ -1604,7 +1611,7 @@ dri2_create_wayland_buffer_from_image(_EGLDriver *drv, _EGLDisplay *dpy,
>     return dri2_dpy->vtbl->create_wayland_buffer_from_image(drv, dpy, img);
>  }
>
> -#ifdef HAVE_LIBDRM
> +#if defined(HAVE_DRM_PLATFORM) || defined(HAVE_SURFACELESS_PLATFORM)
My earlier comment was aimed at every instance of such change -
perhaps I was unclear about it. I.e. the one you're dropped, this ...

>  static EGLBoolean
>  dri2_check_dma_buf_attribs(const _EGLImageAttribs *attrs)
>  {
> @@ -1862,7 +1869,7 @@ dri2_create_image_khr(_EGLDriver *drv, _EGLDisplay *disp,
>     case EGL_WAYLAND_BUFFER_WL:
>        return dri2_create_image_wayland_wl_buffer(disp, ctx, buffer, attr_list);
>  #endif
> -#ifdef HAVE_LIBDRM
> +#if defined(HAVE_DRM_PLATFORM) || defined(HAVE_SURFACELESS_PLATFORM)
... and this should go imho.

Thanks
Emil