[Mesa-dev] [PATCH 0.5/3] mesa: Handle integer formats in need_rgb_to_luminance_conversion()

Anuj Phogat anuj.phogat at gmail.com
Thu Jun 11 17:15:51 PDT 2015


On Thu, Jun 11, 2015 at 10:05 AM, Tapani Pälli <tapani.palli at intel.com> wrote:
> Reviewed-by: Tapani Pälli <tapani.palli at intel.com>
>
>
> On 06/11/2015 07:58 PM, Anuj Phogat wrote:
>>
>> Signed-off-by: Anuj Phogat <anuj.phogat at gmail.com>
>> ---
>>   src/mesa/main/readpix.c | 5 ++++-
>>   1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/src/mesa/main/readpix.c b/src/mesa/main/readpix.c
>> index df46f83..9166a50 100644
>> --- a/src/mesa/main/readpix.c
>> +++ b/src/mesa/main/readpix.c
>> @@ -54,7 +54,10 @@ need_rgb_to_luminance_conversion(mesa_format texFormat,
>> GLenum format)
>>      return (baseTexFormat == GL_RG ||
>>              baseTexFormat == GL_RGB ||
>>              baseTexFormat == GL_RGBA) &&
>> -          (format == GL_LUMINANCE || format == GL_LUMINANCE_ALPHA);
>> +          (format == GL_LUMINANCE ||
>> +           format == GL_LUMINANCE_ALPHA ||
>> +           format == GL_LUMINANCE_INTEGER_EXT ||
>> +           format == GL_LUMINANCE_ALPHA_INTEGER_EXT);
>>   }
>>
>
>
A note to myself:
I would like to change the signature of this function and just pass the
base formats of src, dst. I will do that later in a separate patch.


More information about the mesa-dev mailing list