[Mesa-dev] [PATCH 2/2] egl/glx: Use helper function to open devices to ensure CLOEXEC is set

[Derek Foreman]

On 12/06/15 06:04 PM, Emil Velikov wrote:
> On 12/06/15 19:07, Derek Foreman wrote:
>> We do this right almost everywhere already, but the idiom is a little
>> gruesome.  This moves it into loader.c and fixes dri2_initialize_drm()
>> which could open without CLOEXEC in some cases.
>>
>> Signed-off-by: Derek Foreman <derekf at osg.samsung.com>
>> ---
>>  src/egl/drivers/dri2/platform_drm.c     |  4 ++--
>>  src/egl/drivers/dri2/platform_wayland.c | 11 +----------
>>  src/egl/drivers/dri2/platform_x11.c     | 12 ++----------
>>  src/glx/dri2_glx.c                      | 10 +---------
>>  src/loader/loader.c                     |  6 +++---
>>  src/loader/loader.h                     |  3 +++
>>  6 files changed, 12 insertions(+), 34 deletions(-)
> 
> Despite that it's on the trivial side, can we please split this into 3
> patches:
>  1) s/static int drm_open_device/int loader_drm_open_device/
>  2) Use in libEGL (new EGL platform - "surfaceless" will land on Monday,
> so better wait for that one to land as well)
>  3) Use in libGL
> 
> I'll throw in with similar patches for VL (for the video
> targets/drivers) and pipe-loader (OpenCL).

Sounds good, I've done that now - I'll wait til monday to handle
platform_surfaceless and send the lot.