[Mesa-dev] [PATCH 2/5] applegl: Provide requirements of _SET_DrawBuffers

Emil Velikov emil.l.velikov at gmail.com
Thu Jun 18 11:23:10 PDT 2015


On 18 June 2015 at 06:53, Julien Isorce <julien.isorce at gmail.com> wrote:
> From: Jon TURNEY <jon.turney at dronecode.org.uk>
>
> _SET_DrawBuffers requires driDispatchRemapTable,
> so we need to link with libmesa for remap.c.
> libmesa requires the C++ linker.
>
> Also need to arrange to call _mesa_init_remap_table()
> to initialize the remap table.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=90311
> Signed-off-by: Jon TURNEY <jon.turney at dronecode.org.uk>
> ---
>  src/glx/Makefile.am         | 5 ++++-
>  src/glx/apple/apple_glapi.c | 3 +++
>  2 files changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/src/glx/Makefile.am b/src/glx/Makefile.am
> index 6e50e09..de24496 100644
> --- a/src/glx/Makefile.am
> +++ b/src/glx/Makefile.am
> @@ -139,7 +139,10 @@ libglx_la_SOURCES += \
>         applegl_glx.c
>
>  SUBDIRS += apple
> -libglx_la_LIBADD += $(builddir)/apple/libappleglx.la
> +libglx_la_LIBADD += \
> +       $(builddir)/apple/libappleglx.la \
> +       $(top_builddir)/src/mesa/libmesa.la
> +nodist_EXTRA_lib at GL_LIB@_la_SOURCES = dummy.cpp
Pulling hunks of mesa into libGL does not sounds like a reasonable
thing. There is a reason why Jon had that XXX: in the original commit
message.

Cheers,
Emil


More information about the mesa-dev mailing list