[Mesa-dev] [PATCH 0/4] CLOEXEC fix-ups

Emil Velikov emil.l.velikov at gmail.com
Thu Jun 18 11:49:08 PDT 2015


On 17 June 2015 at 17:28, Derek Foreman <derekf at osg.samsung.com> wrote:
> This series catches a couple of places where we forget to set CLOEXEC on
> file descriptors, and makes a helper function for the necessarily ugly
> way we have to open fds to make sure CLOEXEC is set.
>
> Derek Foreman (4):
>   egl/drm: Duplicate fd with F_DUPFD_CLOEXEC to prevent leak
>   loader: Rename drm_open_device() to loader_open_device() and share it
>   glx: Use loader_open_device() helper
>   egl: Use the loader_open_device() helper to do open with CLOEXEC
>
>  src/egl/drivers/dri2/platform_drm.c         |  6 +++---
>  src/egl/drivers/dri2/platform_surfaceless.c | 11 +----------
>  src/egl/drivers/dri2/platform_wayland.c     | 11 +----------
>  src/egl/drivers/dri2/platform_x11.c         | 12 ++----------
>  src/glx/dri2_glx.c                          | 10 +---------
>  src/loader/loader.c                         |  6 +++---
>  src/loader/loader.h                         |  3 +++
>  7 files changed, 14 insertions(+), 45 deletions(-)
Series looks great. Thanks for the help Derek.
Reviewed-by: Emil Velikov <emil.l.velikov at gmail.com>

Will give it a couple of days, and barring any objections I'll push
this to master.

-Emil


More information about the mesa-dev mailing list