[Mesa-dev] [PATCH] i965: Add missing braces around if-statement.

Kenneth Graunke kenneth at whitecape.org
Thu Jun 18 16:40:15 PDT 2015


On Thursday, June 18, 2015 04:28:25 PM Ben Widawsky wrote:
> 
> On Thu, Jun 18, 2015 at 04:19:36PM -0700, Matt Turner wrote:
> > Fixes a performance problem caused by commit b639ed2f.
> > 
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=90895
> 
> Ken spotted this in review.
> /me hides
> 
> Reviewed-by: Ben Widawsky <ben at bwidawsk.net>

Scratch one mystery!  Thanks Matt.

Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>

> 
> > ---
> >  src/mesa/drivers/dri/i965/brw_meta_fast_clear.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/src/mesa/drivers/dri/i965/brw_meta_fast_clear.c b/src/mesa/drivers/dri/i965/brw_meta_fast_clear.c
> > index c0c8dfa..49f2e3e 100644
> > --- a/src/mesa/drivers/dri/i965/brw_meta_fast_clear.c
> > +++ b/src/mesa/drivers/dri/i965/brw_meta_fast_clear.c
> > @@ -339,12 +339,13 @@ is_color_fast_clear_compatible(struct brw_context *brw,
> >                                 mesa_format format,
> >                                 const union gl_color_union *color)
> >  {
> > -   if (_mesa_is_format_integer_color(format))
> > +   if (_mesa_is_format_integer_color(format)) {
> >        if (brw->gen >= 8) {
> >           perf_debug("Integer fast clear not enabled for (%s)",
> >                      _mesa_get_format_name(format));
> >        }
> >        return false;
> > +   }
> >  
> >     for (int i = 0; i < 4; i++) {
> >        if (color->f[i] != 0.0 && color->f[i] != 1.0 &&
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20150618/7227c75b/attachment.sig>


More information about the mesa-dev mailing list