[Mesa-dev] [PATCH 2/2] glapi: remap_helper.py: remove unused argument 'es'

Jose Fonseca jfonseca at vmware.com
Fri Jun 19 05:29:58 PDT 2015


I only did minor tweaks to these files, but the series LGTM.

Reviewed-by: Jose Fonseca <jfonseca at vmware.com>


On 19/06/15 13:21, Emil Velikov wrote:
> Identical to the previous commit - unused by neither the Autotools,
> Android or SCons build.
>
> XXX: There are no more users of gl_api.filter_functions_by_api(). Should
> we just nuke it ?
>
> Cc:  Dylan Baker <dylanx.c.baker at intel.com>
> Cc:  Jose Fonseca <jfonseca at vmware.com>
> Signed-off-by: Emil Velikov <emil.l.velikov at gmail.com>
> ---
>   src/mapi/glapi/gen/remap_helper.py | 8 --------
>   1 file changed, 8 deletions(-)
>
> diff --git a/src/mapi/glapi/gen/remap_helper.py b/src/mapi/glapi/gen/remap_helper.py
> index 94ae193..edc6c3e 100644
> --- a/src/mapi/glapi/gen/remap_helper.py
> +++ b/src/mapi/glapi/gen/remap_helper.py
> @@ -174,12 +174,6 @@ def _parser():
>                           metavar="input_file_name",
>                           dest='file_name',
>                           help="An xml description file.")
> -    parser.add_argument('-c', '--es-version',
> -                        choices=[None, 'es1', 'es2'],
> -                        default=None,
> -                        metavar='ver',
> -                        dest='es',
> -                        help='A GLES version to support')
>       return parser.parse_args()
>
>
> @@ -188,8 +182,6 @@ def main():
>       args = _parser()
>
>       api = gl_XML.parse_GL_API(args.file_name)
> -    if args.es is not None:
> -        api.filter_functions_by_api(args.es)
>
>       printer = PrintGlRemap()
>       printer.Print(api)
>



More information about the mesa-dev mailing list