[Mesa-dev] [PATCH 3/3] egl/main: expose the EGL_RECORDABLE_ANDROID extension

[Emil Velikov]

Hi Chih-Wei,

On 19 June 2015 at 17:50, Chih-Wei Huang <cwhuang at android-x86.org> wrote:
> Signed-off-by: Chih-Wei Huang <cwhuang at linux.org.tw>
> ---
>  src/egl/main/eglconfig.c | 5 ++++-
>  src/egl/main/eglconfig.h | 2 ++
>  2 files changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/src/egl/main/eglconfig.c b/src/egl/main/eglconfig.c
> index cf65c69..d9971ed 100644
> --- a/src/egl/main/eglconfig.c
> +++ b/src/egl/main/eglconfig.c
> @@ -245,7 +245,10 @@ static const struct {
>     /* extensions */
>     { EGL_Y_INVERTED_NOK,            ATTRIB_TYPE_BOOLEAN,
>                                      ATTRIB_CRITERION_EXACT,
> -                                    EGL_DONT_CARE }
> +                                    EGL_DONT_CARE },
> +   { EGL_RECORDABLE_ANDROID,        ATTRIB_TYPE_BOOLEAN,
> +                                    ATTRIB_CRITERION_EXACT,
> +                                    EGL_DONT_CARE },
>  };
>
>
> diff --git a/src/egl/main/eglconfig.h b/src/egl/main/eglconfig.h
> index 84cb227..7121b3d 100644
> --- a/src/egl/main/eglconfig.h
> +++ b/src/egl/main/eglconfig.h
> @@ -86,6 +86,7 @@ struct _egl_config
>
>     /* extensions */
>     EGLint YInvertedNOK;
> +   EGLint RecordableAndroid;
>  };
>
>
> @@ -133,6 +134,7 @@ _eglOffsetOfConfig(EGLint attr)
>     ATTRIB_MAP(EGL_CONFORMANT,                Conformant);
>     /* extensions */
>     ATTRIB_MAP(EGL_Y_INVERTED_NOK,            YInvertedNOK);
> +   ATTRIB_MAP(EGL_RECORDABLE_ANDROID,        RecordableAndroid);
I believe what Eric meant earlier was that - in order for the extra
token to be recognised one needs to implement(and advertise) the whole
EGL_ANDROID_recordable extension. From a quick look at the spec, this
means adding a _EGL_CHECK_EXTENSION() _eglCreateExtensionsString and
making use of the value, rather than just accepting the new token.

If you write a piglit test or two that would be amazing :-)

Cheers,
Emil