[Mesa-dev] [PATCH v2 02/18] i965/fs: Fix fs_inst::regs_read() for uniform pull constant loads

Jason Ekstrand jason at jlekstrand.net
Fri Jun 19 18:05:12 PDT 2015


On Fri, Jun 19, 2015 at 1:51 PM, Matt Turner <mattst88 at gmail.com> wrote:
> On Fri, Jun 19, 2015 at 1:18 PM, Jason Ekstrand <jason at jlekstrand.net> wrote:
>> Previously, fs_inst::regs_read() fell back to depending on the register
>> width for the second source.  This isn't really correct since it isn't a
>> SIMD8 value at all, but a SIMD4x2 value.  This commit changes it to
>> explicitly be always one register.
>>
>> Reviewed-by: Iago Toral Quiroga <itoral at igalia.com>
>>
>> v2: Use mlen for determining the number of registers written
>> ---
>>  src/mesa/drivers/dri/i965/brw_fs.cpp | 6 ++++++
>>  1 file changed, 6 insertions(+)
>>
>> diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp b/src/mesa/drivers/dri/i965/brw_fs.cpp
>> index 17a940b..6d25ba4 100644
>> --- a/src/mesa/drivers/dri/i965/brw_fs.cpp
>> +++ b/src/mesa/drivers/dri/i965/brw_fs.cpp
>> @@ -758,6 +758,12 @@ fs_inst::regs_read(int arg) const
>>           return mlen;
>>        break;
>>
>> +   case FS_OPCODE_UNIFORM_PULL_CONSTANT_LOAD_GEN7:
>> +      /* The payload is actually storred in src1 */
>
> stored just has one r
Thanks!  Fixed locally.
--Jason


More information about the mesa-dev mailing list