[Mesa-dev] [PATCH] mesa: Delete unused ICEIL().

Jordan Justen jordan.l.justen at intel.com
Mon Jun 22 15:06:30 PDT 2015


Reviewed-by: Jordan Justen <jordan.l.justen at intel.com>

On 2015-06-22 14:58:27, Matt Turner wrote:
> Can't find any uses of it in git history.
> ---
> Strangely, when it was moved to its current location in commit 27558a1,
> it was moved from mmath.h... which seems to have been lost from git's
> history. Searching further git log --grep mmath.h shows that various
> commit messages mention modifying mmath.h and none of the commits
> actually do.
> 
>  src/mesa/main/imports.h | 32 --------------------------------
>  1 file changed, 32 deletions(-)
> 
> diff --git a/src/mesa/main/imports.h b/src/mesa/main/imports.h
> index c4d917e..9ffe3de 100644
> --- a/src/mesa/main/imports.h
> +++ b/src/mesa/main/imports.h
> @@ -230,38 +230,6 @@ static inline int IFLOOR(float f)
>  }
>  
>  
> -/** Return (as an integer) ceiling of float */
> -static inline int ICEIL(float f)
> -{
> -#if defined(USE_X86_ASM) && defined(__GNUC__) && defined(__i386__)
> -   /*
> -    * IEEE ceil for computers that round to nearest or even.
> -    * 'f' must be between -4194304 and 4194303.
> -    * This ceil operation is done by "(iround(f + .5) + iround(f - .5) + 1) >> 1",
> -    * but uses some IEEE specific tricks for better speed.
> -    * Contributed by Josh Vanderhoof
> -    */
> -   int ai, bi;
> -   double af, bf;
> -   af = (3 << 22) + 0.5 + (double)f;
> -   bf = (3 << 22) + 0.5 - (double)f;
> -   /* GCC generates an extra fstp/fld without this. */
> -   __asm__ ("fstps %0" : "=m" (ai) : "t" (af) : "st");
> -   __asm__ ("fstps %0" : "=m" (bi) : "t" (bf) : "st");
> -   return (ai - bi + 1) >> 1;
> -#else
> -   int ai, bi;
> -   double af, bf;
> -   fi_type u;
> -   af = (3 << 22) + 0.5 + (double)f;
> -   bf = (3 << 22) + 0.5 - (double)f;
> -   u.f = (float) af; ai = u.i;
> -   u.f = (float) bf; bi = u.i;
> -   return (ai - bi + 1) >> 1;
> -#endif
> -}
> -
> -
>  /**
>   * Is x a power of two?
>   */
> -- 
> 2.3.6
> 
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list