[Mesa-dev] [PATCH 06/17] i965/blorp: Explicitly set execution sizes for new'd instructions

[Pohjolainen, Topi]

On Thu, Jun 18, 2015 at 05:51:35PM -0700, Jason Ekstrand wrote:
> This doesn't affect instructions allocated using the builder.
> ---
>  src/mesa/drivers/dri/i965/brw_blorp_blit_eu.cpp | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)

Reviewed-by: Topi Pohjolainen <topi.pohjolainen at intel.com>

> 
> diff --git a/src/mesa/drivers/dri/i965/brw_blorp_blit_eu.cpp b/src/mesa/drivers/dri/i965/brw_blorp_blit_eu.cpp
> index c1b7609..f655a0c 100644
> --- a/src/mesa/drivers/dri/i965/brw_blorp_blit_eu.cpp
> +++ b/src/mesa/drivers/dri/i965/brw_blorp_blit_eu.cpp
> @@ -72,7 +72,7 @@ brw_blorp_eu_emitter::emit_kill_if_outside_rect(const struct brw_reg &x,
>     emit_cmp(BRW_CONDITIONAL_L, x, dst_x1)->predicate = BRW_PREDICATE_NORMAL;
>     emit_cmp(BRW_CONDITIONAL_L, y, dst_y1)->predicate = BRW_PREDICATE_NORMAL;
>  
> -   fs_inst *inst = new (mem_ctx) fs_inst(BRW_OPCODE_AND, g1, f0, g1);
> +   fs_inst *inst = new (mem_ctx) fs_inst(BRW_OPCODE_AND, 16, g1, f0, g1);
>     inst->force_writemask_all = true;
>     insts.push_tail(inst);
>  }
> @@ -83,7 +83,7 @@ brw_blorp_eu_emitter::emit_texture_lookup(const struct brw_reg &dst,
>                                            unsigned base_mrf,
>                                            unsigned msg_length)
>  {
> -   fs_inst *inst = new (mem_ctx) fs_inst(op, dst, brw_message_reg(base_mrf),
> +   fs_inst *inst = new (mem_ctx) fs_inst(op, 16, dst, brw_message_reg(base_mrf),
>                                           fs_reg(0u));
>  
>     inst->base_mrf = base_mrf;
> @@ -118,7 +118,8 @@ brw_blorp_eu_emitter::emit_combine(enum opcode combine_opcode,
>  {
>     assert(combine_opcode == BRW_OPCODE_ADD || combine_opcode == BRW_OPCODE_AVG);
>  
> -   insts.push_tail(new (mem_ctx) fs_inst(combine_opcode, dst, src_1, src_2));
> +   insts.push_tail(new (mem_ctx) fs_inst(combine_opcode, 16, dst,
> +                                         src_1, src_2));
>  }
>  
>  fs_inst *
> @@ -126,7 +127,7 @@ brw_blorp_eu_emitter::emit_cmp(enum brw_conditional_mod op,
>                                 const struct brw_reg &x,
>                                 const struct brw_reg &y)
>  {
> -   fs_inst *cmp = new (mem_ctx) fs_inst(BRW_OPCODE_CMP,
> +   fs_inst *cmp = new (mem_ctx) fs_inst(BRW_OPCODE_CMP, 16,
>                                          vec16(brw_null_reg()), x, y);
>     cmp->conditional_mod = op;
>     insts.push_tail(cmp);
> -- 
> 2.4.3
> 
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev