[Mesa-dev] [PATCH] Fix strict-aliasing violations in GLSL shader list implementation

Davin McCall davmac at davmac.org
Wed Jun 24 15:29:42 PDT 2015

Hi Ilia (and Matt and Thomas)

On 23/06/15 22:30, Ilia Mirkin wrote:
> The biggest part of the process is to send a proper commit to the
> mailing list. There are two issues with your mailing (without
> commenting on your actual changes) --
> (a) The patch is attached, not inlined
> (b) You sent a diff, not a commit
> Both of these are easily resolved by using 'git send-email' for your
> patches, but that's not a strict requirement. See
> http://mesa3d.org/devinfo.html#submitting .

Thanks for responding! I'll look into sending the patch using 'git 
send-email'.I'm still fairly new to git.

> Since you're increasing the storage requirements of a pretty basic
> unit of storage in mesa, it may also be interesting to see memory
> usage of some non-trivial trace or game before & after. While I think
> that's optional, it's definitely a nice-to-have.

Right, I'll see if I can produce something meaningful.


More information about the mesa-dev mailing list