[Mesa-dev] [PATCH v2 0/7] port _mesa_strto[df] to C

Matt Turner mattst88 at gmail.com
Thu Jun 25 16:10:12 PDT 2015

On Thu, Jun 25, 2015 at 2:05 PM, Erik Faye-Lund <kusmabite at gmail.com> wrote:
> Back in March[1], I sent a patch porting _mesa_strto[df] to
> C rather than C++. I fixed up the patch according to the
> criticism, but unfortunately I dropped the ball before I sent
> out the result. So here I am, picking it back up!
> This time I've taken a deeper dive into the whole init/deinit
> of Mesa, and cleaned up a bunch of stuff in that area. And as
> a result, this time we end up freeing the locale also.
> No Piglit regressions observed.
> [1]: <1426446329-23984-1-git-send-email-kusmabite at gmail.com>
> Erik Faye-Lund (7):
>   mesa/main: Get rid of outdated GDB-hack
>   dri: don't touch the shader compiler
>   mesa/main: only call _mesa_destroy_shader_compiler once on exit
>   glsl: No need to lock in _mesa_glsl_release_types
>   util: port _mesa_strto[df] to C
>   mesa/main: free locale at exit
>   util: assert to verify that locale is initialized

Thanks for this! The series looks good to me.

I'm slightly worried about 2/7, but not for any reasons other than I'm
not very familiar with that code.

1-6 (with the caveat that I may not have any idea what I'm saying
about 2/7 ;) are:

Reviewed-by: Matt Turner <mattst88 at gmail.com>

7/7 looks like it may have been useful for debugging, but I don't
think we should necessarily commit it.

More information about the mesa-dev mailing list