[Mesa-dev] [PATCH 2/2] i965: Delete linked GLSL IR when using NIR.
kenneth at whitecape.org
Fri Jun 26 14:30:58 PDT 2015
On Thursday, June 25, 2015 02:29:13 PM Tapani Pälli wrote:
> Huh I see this went in already, I've noticed a problem and thought to
> share it.
> Currently program resource list (used by gl api shader queries) is
> generated in linker, before backend LinkShader call. What this means is
> that it relies on frontend optimization passes to get rid of dead inputs
> and outputs. But .. this does not seem to always happen, sometimes these
> get removed only during backend optimization passes. I have a bug on
> this as #90925.
> There's 2 possibilities to move with this, either move resource list
> creation to happen after LinkShader (which would mean we should not free
> IR during LinkShader) or try to fix frontend dead code removal to
> recognize the case in the bug. I will keep digging why the variable in
> question is not recognized by the frontend passes, just wanted to let
> you know!
Sorry, I didn't see any indication on the mailing list that the patches
were broken, so I thought there were reviewed-and-ready-to-push patches
that just hadn't gone in. So I did a Piglit run and pushed them.
Feel free to revert if they're not baked yet.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 819 bytes
Desc: This is a digitally signed message part.
More information about the mesa-dev