[Mesa-dev] [PATCH v3 6/6] mesa/main: free locale at exit

[Erik Faye-Lund]

On Fri, Jun 26, 2015 at 9:05 PM, Brian Paul <brianp at vmware.com> wrote:
> On 06/26/2015 12:06 PM, Erik Faye-Lund wrote:
>>
>> In order to save a small leak if mesa is continously loaded and
>> unloaded, let's free the locale when the shared object is unloaded.
>>
>> Signed-off-by: Erik Faye-Lund <kusmabite at gmail.com>
>> Reviewed-by: Matt Turner <mattst88 at gmail.com>
>> ---
>>   src/mesa/main/context.c | 12 +++++++++++-
>>   src/util/strtod.c       |  8 ++++++++
>>   src/util/strtod.h       |  3 +++
>>   3 files changed, 22 insertions(+), 1 deletion(-)
>>
>> diff --git a/src/mesa/main/context.c b/src/mesa/main/context.c
>> index e68de68..dee1fa8 100644
>> --- a/src/mesa/main/context.c
>> +++ b/src/mesa/main/context.c
>> @@ -346,6 +346,16 @@ _mesa_destroy_visual( struct gl_config *vis )
>>   mtx_t OneTimeLock = _MTX_INITIALIZER_NP;
>>
>>
>> +/**
>> + * Calls all the various one-time-fini functions in Mesa
>> + */
>> +
>> +static void
>> +one_time_fini()
>
>
> I think that should be one_time_fini(void) to be consistent and to avoid
> warnings with some compilers.

Good eyes, I've fixed that locally. Thanks :)

> Otherwise, the series looks good to me.  Nice to see patch 1.  I remember
> writing that dumb code years ago.
>
> Reviewed-by: Brian Paul <brianp at vmware.com>

Thanks. Is that Reviewed-by for this patch, or the whole series?