[Mesa-dev] [PATCH] mesa/st: Add checks for signed/unsigned integer conversions in ReadPixels

Michel Dänzer michel at daenzer.net
Tue Jun 30 00:06:23 PDT 2015

On 29.06.2015 17:44, Iago Toral Quiroga wrote:
> These checks were in Mesa prior to commit fbba25bba, but they were
> not necessary for the purpose that Mesa intended (check if we could
> resolve ReadPixels via memcpy), so that commit took them away.
> Unfortunately, it seems that some Gallium drivers rely on these
> checks to make the decision of whether they should fallback to Mesa's
> implementation of ReadPixels correctly. Micahel Dänzer reported that

Typo: "Michel"

> the following piglit test would fail on radeonsi after commit
> fbba25bba:
> spec at ext_texture_integer@fbo_integer_readpixels_sint_uint
> This patch puts the checks back in Gallium, where they are needed.
> ---
> Michel, can you confirm that this fixes piglit with radeonsi?

It does, thanks.

Tested-by: Michel Dänzer <michel.daenzer at amd.com>

Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer

More information about the mesa-dev mailing list