[Mesa-dev] [PATCH] configure: simplify visibility compiler flagdetection

[Marc Dietrich]

Am Sonntag 01 März 2015, 13:05:52 schrieb Alan Coopersmith:
> On 03/ 1/15 10:57 AM, Emil Velikov wrote:
> > On 01/03/15 18:30, Matt Turner wrote:
> >> On Sun, Mar 1, 2015 at 6:09 AM, Marc Dietrich <marvin24 at gmx.de> wrote:
> >>> This patch simplifies the visibility compiler flag detection in
> >>> configure and makes it more generic to also support compilers other
> >>> than gcc.
> >> 
> >> This simplification relies on the assumption that compilers support
> >> -fvisibility=... if and only if they support
> >> attribute(visibility("...")).
> > 
> > Hmm you're correct. I've naively assumed they both go hand in hand.
> 
> The latest Solaris Studio compilers support attribute(visibility), but
> not -fvisibility.  The absolute latest (12.4, released a few months back)
> also support the clang has_attribute() extension for checking what's
> supported (which is one of the reasons it's used in the X11/Xfuncproto.h
> header in xproto 7.0.27 & later).
> 
> https://docs.oracle.com/cd/E37069_01/html/E37074/gjzke.html
> https://docs.oracle.com/cd/E37069_01/html/E37074/gopqx.html
> http://cgit.freedesktop.org/xorg/proto/x11proto/commit/?id=ffd4a13042d24cb5c
> 913207585191801a9a1603e

thanks for this information, Alan. Now for me it looks like that the original 
code was probably not so bad as it checks for -fvisibility directly.

Marc
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20150301/c22dd3ec/attachment-0001.sig>