[Mesa-dev] [PATCH] configure: simplify visibility compiler flag detection

[Emil Velikov]

On 3 March 2015 at 05:21, Alan Coopersmith <alan.coopersmith at oracle.com> wrote:
> On 03/ 1/15 02:31 PM, Emil Velikov wrote:
>>
>>   - Considering the lack of -fvisibility, what is the normal visibility
>> "level" - hidden or default ? If the latter this means that every
>> library/module built exports a ton of internal symbols.
>
>
> Default, unless you pass the -xldscope=hidden flag to Studio, as the
> Xserver does:
>
> http://cgit.freedesktop.org/xorg/xserver/tree/configure.ac?id=xorg-server-1.17.1#n1840
>
Would you mind rolling a similar patch for mesa, and testing it out.
I'm suspecting that mesa is missing a few PUBLIC annotations. I will
roll a similar one for libdrm, as I'm pretty sure it ought to be safe.

Btw did we manage to get through with all the build issues for mesa
10.4/10.5 ? If there is something blocking it, please do shout/file a
bug - when you have the time of course :-)


>>   - Using the __has_attribute macro looks great, although I would suspect
>> that it will take a while for GCC and others to adopt(?).
>
>
> Probably, which is why X.Org uses it in addition to, instead of as a
> replacement for, the gcc version checks for now:
>
Ouch.. caffeine deprived brain read your earlier comment as "to replace" :-\


Thanks
Emil