[Mesa-dev] [PATCH] main/base_tex_format: Properly handle STENCIL_INDEX1/4/16

[Jason Ekstrand]

On Mon, Mar 2, 2015 at 11:18 AM, Ilia Mirkin <imirkin at alum.mit.edu> wrote:

> Hmmm... I was just looking at this code in connection to attepmting to
> enable ARB_texture_stencil8, and it _seems_ like that should be if
> (ARB_texture_stencil8) -- I didn't see what in ARB_stencil_texturing
> had to do with being able to have a GL_STENCIL_INDEX* internal
> format...
>

I just pushed it because it does fix a bug...  However, you do raise a good
point.  Maybe we should change the i965 driver to use GL_STENCIL_INDEX for
the internal format for our internal stencil buffers.
--Jason


>   -ilia
>
> On Fri, Feb 27, 2015 at 6:55 PM, Jason Ekstrand <jason at jlekstrand.net>
> wrote:
> > From: Jason Ekstrand <jason at jlekstrand.net>
> >
> > This takes "fbo-stencil blit GL_STENCIL_INDEX1/4/16" from crash to pass
> on
> > BDW.
> > ---
> >  src/mesa/main/teximage.c | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c
> > index 6e45cc9..a68574d 100644
> > --- a/src/mesa/main/teximage.c
> > +++ b/src/mesa/main/teximage.c
> > @@ -224,7 +224,10 @@ _mesa_base_tex_format( struct gl_context *ctx,
> GLint internalFormat )
> >     if (ctx->Extensions.ARB_stencil_texturing) {
> >        switch (internalFormat) {
> >        case GL_STENCIL_INDEX:
> > +      case GL_STENCIL_INDEX1:
> > +      case GL_STENCIL_INDEX4:
> >        case GL_STENCIL_INDEX8:
> > +      case GL_STENCIL_INDEX16:
> >           return GL_STENCIL_INDEX;
> >        default:
> >           ; /* fallthrough */
> > --
> > 2.1.0
> >
> > _______________________________________________
> > mesa-dev mailing list
> > mesa-dev at lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20150302/5ceb3af2/attachment.html>