[Mesa-dev] replace __FUNCTION__ with __func__ task

Brian Paul brianp at vmware.com
Tue Mar 3 09:07:46 PST 2015


On 03/03/2015 09:56 AM, Jose Fonseca wrote:
> On 03/03/15 15:57, Brian Paul wrote:
>> We're using both of these in Mesa/gallium.  It would be nice to
>> consistently just use C99's __func__ everywhere.  This would be any easy
>> task for someone looking for something simple to do.
>>
>> We could then get rid of this (broken) chunk seen in both compiler.h and
>> p_compiler.h:
>>
>> #ifndef __FUNCTION__
>> #  define __FUNCTION__ __func__
>> #endif
>
> Sounds good to me.  Note that MSVC doesn't support __func__, only
> __FUNCTION__, so we need to ensure that c99_compat.h gets included
> everywhere.

Right.  That should already be the case since it's included by 
src/mesa/main/compiler.h which gets included almost everywhere already.

-Brian




More information about the mesa-dev mailing list