[Mesa-dev] replace __FUNCTION__ with __func__ task

[Jan Vesely]

On Tue, 2015-03-03 at 10:07 -0700, Brian Paul wrote:
> On 03/03/2015 09:56 AM, Jose Fonseca wrote:
> > On 03/03/15 15:57, Brian Paul wrote:
> >> We're using both of these in Mesa/gallium.  It would be nice to
> >> consistently just use C99's __func__ everywhere.  This would be any easy
> >> task for someone looking for something simple to do.
> >>
> >> We could then get rid of this (broken) chunk seen in both compiler.h and
> >> p_compiler.h:
> >>
> >> #ifndef __FUNCTION__
> >> #  define __FUNCTION__ __func__
> >> #endif
> >
> > Sounds good to me.  Note that MSVC doesn't support __func__, only
> > __FUNCTION__, so we need to ensure that c99_compat.h gets included
> > everywhere.
> 
> Right.  That should already be the case since it's included by 
> src/mesa/main/compiler.h which gets included almost everywhere already.

would it make sense to add -imacros/-include cmdline options for these
headers?
I have no idea whether these are supported by other compilers (at least
-include is supported by clang)

jan

> 
> -Brian
> 
> 
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev


-- 
Jan Vesely <jan.vesely at rutgers.edu>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20150303/d7dca7d4/attachment.sig>