[Mesa-dev] [Bug 86326] clEnqueueNDRangeKernel global_work_offset ignored

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=86326

--- Comment #4 from Tom Stellard <tstellar at gmail.com> ---
Comment on attachment 114336
  --> https://bugs.freedesktop.org/attachment.cgi?id=114336
LLVM AMDGPU get_global_offset() patch

Review of attachment 114336:
-----------------------------------------------------------------

Hi, Thanks for the patch.  After making the changes below, could you send the
new patch to llvm-commits at cs.uiuc.edu?

::: lib/Target/R600/SIInstrInfo.h
@@ -371,4 +371,4 @@
> >    GLOBAL_SIZE_Z = 20,
> >    LOCAL_SIZE_X = 24,
> >    LOCAL_SIZE_Y = 28,
> > -  LOCAL_SIZE_Z = 32
> > +  LOCAL_SIZE_Z = 32,

> > +  LOCAL_SIZE_Z = 32,

This additional comma is unnecessary.

We should add another enum here for KernelABIInputOffsets and then add entries
for WORK_DIM and GLOBAL_OFFSET_{X,Y,Z}, and use these instead of constants in
SIISelLowering.cp

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20150316/fb369404/attachment.html>